chore(refs): pin all @develop refs to v1.18.0 in workflows and v1.x.x in READMEs#160
chore(refs): pin all @develop refs to v1.18.0 in workflows and v1.x.x in READMEs#160
Conversation
… in README examples
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughPinned shared GitHub Actions references from moving branches to fixed tags (mostly Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Lint Analysis
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release-notification.yml (1)
130-141:⚠️ Potential issue | 🟠 MajorQuote
$GITHUB_OUTPUTin redirection target at line 141.The unquoted variable expansion triggers shellcheck SC2086 and blocks PR validation. Word-splitting can occur if the variable contains whitespace or special characters.
Fix
- echo "tag=$TAG" >> $GITHUB_OUTPUT + echo "tag=$TAG" >> "$GITHUB_OUTPUT"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release-notification.yml around lines 130 - 141, The redirection target $GITHUB_OUTPUT should be quoted to avoid word-splitting (ShellCheck SC2086); update the final echo that writes the output variable (the line using echo "tag=$TAG" >> $GITHUB_OUTPUT) to quote the expansion (use ">> \"$GITHUB_OUTPUT\"" or equivalent) so the redirection is safe when GITHUB_OUTPUT contains spaces or special characters; ensure the change is applied in the block that resolves TAG and writes the output.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/release-notification.yml:
- Around line 130-141: The redirection target $GITHUB_OUTPUT should be quoted to
avoid word-splitting (ShellCheck SC2086); update the final echo that writes the
output variable (the line using echo "tag=$TAG" >> $GITHUB_OUTPUT) to quote the
expansion (use ">> \"$GITHUB_OUTPUT\"" or equivalent) so the redirection is safe
when GITHUB_OUTPUT contains spaces or special characters; ensure the change is
applied in the block that resolves TAG and writes the output.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7756a680-b250-4839-a48f-3b8bbb911e06
📒 Files selected for processing (20)
.github/workflows/branch-cleanup.yml.github/workflows/build.yml.github/workflows/gptchangelog.yml.github/workflows/labels-sync.yml.github/workflows/pr-security-scan.yml.github/workflows/release-notification.yml.github/workflows/release.yml.github/workflows/typescript-build.yml.github/workflows/typescript-release.ymlsrc/lint/composite-schema/README.mdsrc/lint/readme-check/README.mdsrc/lint/shellcheck/README.mdsrc/notify/discord-release/README.mdsrc/notify/pr-lint-reporter/README.mdsrc/notify/slack-notify/README.mdsrc/notify/slack-release/README.mdsrc/security/dockerfile-checks/README.mdsrc/security/pr-security-reporter/README.mdsrc/security/trivy-fs-scan/README.mdsrc/security/trivy-image-scan/README.md
* chore(deps): bump aws-actions/configure-aws-credentials in the aws group Bumps the aws group with 1 update: [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials). Updates `aws-actions/configure-aws-credentials` from 4 to 6 - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v4...v6) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: aws ... Signed-off-by: dependabot[bot] <support@github.com> * chore(refs): pin all @develop refs to v1.18.0 in workflows and v1.x.x in READMEs (#160) * chore(refs): pin all @develop refs to v1.18.0 in workflows and v1.x.x in README examples * fix(lint): quote GITHUB_OUTPUT in release-notification SC2086 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GitHub Actions Shared Workflows
Description
Replaces all
@developreferences with pinned versions:.github/workflows/):@develop→@v1.18.0src/*/README.md):@develop→@v1.x.x(generic stable placeholder)branch-cleanupandlabels-syncREADMEs that explicitly document@developas a testing ref — left unchanged.Type of Change
chore: Dependency bumps, config updates, maintenanceBreaking Changes
None.
Testing
Caller repo / workflow run: N/A — ref-only change, no behavioral difference.
Related Issues
Closes #
Summary by CodeRabbit